Add max_by #379
Closed
Add max_by #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @felipesere! -- thanks so much for this PR! I noticed #384 partially overlaps with this PR. I would've left some notes on this PR, but basically #384 was exactly what I was hoping for these methods, so I've gone ahead and merged that instead. I still want to take a moment to thank you for the work you've done here! -- I've seen you've put in a few patches, and they're all really good! I'm going to go ahead and close this PR in favor of #384, but please don't take it as a discouragement from continuing to contribute. I'm really stoked you've been helping out, and would love to continue to have you here! Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically its was possibly to create an equivalent of max_by by using min_by.
That would have been awkward to read for users though.
I first tried to Box the comparison function and simply passing it down from max_by to min_by with
reverse()applied. That got too tedious and meant users were exposed to the Box.This variation adds a new field to the strut - now renamed MinMaxBy - that tells us whether we are maximising or minimising.